Hello cprince,
I'd like you to do a code review. Please execute
g4 diff -c 10031239
or point your web browser to
http://mondrian/10031239
to review the following code:
Change 10031239 by nigel...@nigeltao-srcwingears5 on 2009/02/06 16:40:04
*pending*
Remove the Skia library binaries, in anticipation of checking in
the Skia source.
This involves temporary disabling the canvas module.
R=cprince
[email protected]
OCL=10031239
Affected files ...
... //depot/googleclient/gears/opensource/gears/Makefile#230 edit
... //depot/googleclient/gears/opensource/gears/factory/factory_impl.cc#24 edit
... //depot/googleclient/gears/opensource/gears/test/testcases/config.js#38 edit
... //depot/googleclient/gears/opensource/gears/tools/config.mk#99 edit
... //depot/googleclient/gears/opensource/gears/tools/rules.mk#102 edit
... //depot/googleclient/gears/opensource/third_party/skia/include/Sk64.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkAutoKern.h#1
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkBitmap.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkBitmapProcState_matrix.h#1
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkBounder.h#3
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkBuffer.h#3
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkCanvas.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkChunkAlloc.h#3
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkColor.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkColorFilter.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkColorMatrix.h#1
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkColorMatrixFilter.h#1
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkColorPriv.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkColorShader.h#1
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkDOM.h#3
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkDeque.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkDescriptor.h#3
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkDevice.h#1
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkDither.h#1
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkDraw.h#1
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkDrawFilter.h#1
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkDrawLooper.h#1
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkFDot6.h#3
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkFixed.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkFlattenable.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkFloatBits.h#1
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkFloatingPoint.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkFontHost.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkGlobals.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkGraphics.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkImageDecoder.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkMMapStream.h#1
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkMask.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkMaskFilter.h#3
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkMath.h#4
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkMatrix.h#3
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkMovie.h#1
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkOSFile.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkPackBits.h#1
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkPaint.h#3
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkPath.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkPathEffect.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkPathMeasure.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkPerspIter.h#1
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkPicture.h#1
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkPixelRef.h#1
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkPoint.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkPorterDuff.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkPostConfig.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkPreConfig.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkPtrRecorder.h#1
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkRandom.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkRasterizer.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkReader32.h#1
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkRect.h#3
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkRefCnt.h#3
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkRegion.h#3
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkScalar.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkScalerContext.h#3
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkShader.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkShaderExtras.h#3
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkStream.h#3
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkString.h#3
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkStroke.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkStrokerPriv.h#1
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkTDArray.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkTSearch.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkTemplates.h#3
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkThread.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkThread_platform.h#3
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkTime.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkTypeface.h#3
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkTypes.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkUnPreMultiply.h#1
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkUserConfig.h#6
delete
... //depot/googleclient/gears/opensource/third_party/skia/include/SkUtils.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkWriter32.h#1
delete
...
//depot/googleclient/gears/opensource/third_party/skia/include/SkXfermode.h#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/libskia-dbg-osx-i386+ppc.a#2
delete
...
//depot/googleclient/gears/opensource/third_party/skia/libskia-opt-osx-i386+ppc.a#2
delete
...
//depot/googleclient/gears/opensource/third_party/skia/skia-dbg-win32-i386.lib#3
delete
...
//depot/googleclient/gears/opensource/third_party/skia/skia-dbg-win32-i386.pdb#2
delete
...
//depot/googleclient/gears/opensource/third_party/skia/skia-opt-win32-i386.lib#2
delete
...
//depot/googleclient/gears/opensource/third_party/skia/skia-opt-win32-i386.pdb#2
delete
<diffstats omitted>
Also consider running:
g4 lint -c 10031239
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
