LGTM On Wed, Feb 11, 2009 at 5:48 AM, Steve Block <[email protected]> wrote:
> > WebKit reportedly has problems with wbr elements > > (http://www.quirksmode.org/oddsandends/wbr.html), do those affect us at > all? > It seems that Chrome supports <wbr>. Opera and Safari do not, so for > wrapping the domain in the permissions dialog, I used ​ as well > as <wbr>. See CL 10066160. > > > Could you send me a screenshot of > > ( > http://www.microsoft.com/israel/windows/ie/ie7/about/customizelinks.mspx) > with > > this change? > I'm having problems installing a new version of Gears in Chrome, so > I've attached a screenshot using IE with the same shortcut name. > > > ======================================================================== > > > http://mondrian.corp.google.com/file/10035225///depot/googleclient/gears/opensource/gears/ui/common/shortcuts_dialog.html_m4?a=1 > > File > //depot/googleclient/gears/opensource/gears/ui/common/shortcuts_dialog.html_m4 > (snapshot 1) > > ------------------------------------ > > Line 378: nameElement.appendChild(document.createElement('wbr')); > > Any reason to only do this in Chrome? > Long shortcut names with '_' characters are only present in shortcuts > on Chrome because the browser takes the page title and replaces '/' > with '_'. Given this, breaking on '_' seemed rather arbitrary on other > browsers. > > Steve >
