LGTM ======================================================================== http://mondrian.corp.google.com/file/10099212///depot/googleclient/gears/opensource/gears/Makefile?a=3 File //depot/googleclient/gears/opensource/gears/Makefile (snapshot 3) ------------------------------------ Line 373: ifneq ($(OFFICIAL_BUILD),1) If you want to be consistent, you could make this "ifeq" and add a comment explaining which API Skia corresponds to.
ifeq ($(OFFICIAL_BUILD),1) # The Canvas API is not yet enabled in official builds. #else ======================================================================== http://mondrian.corp.google.com/file/10099212///depot/googleclient/gears/opensource/gears/tools/config.mk?a=5 File //depot/googleclient/gears/opensource/gears/tools/config.mk (snapshot 5) ------------------------------------ Line 149: # Enable/disable various features on Android Any idea whether Skia works on Android and WinMo? You may want to speak with Andrei, and disable Skia here if appropriate. ------------------------------------ Line 816: SKIA_COMPILE_FLAGS += /wd4244 /wd4800 Any reason not to use CPPFLAGS for consistency here? ======================================================================== -- To respond, reply to this email or visit http://mondrian.corp.google.com/10099212
