Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 10212738
or point your web browser to
http://mondrian/10212738
(this changelist has been uploaded to Mondrian)
to review the following code:
Change 10212738 by stevebl...@steveblock-gearslinux1 on 2009/02/19 13:24:37
*pending*
Disables testReadyStates for Chrome.
PRESUBMIT=passed
R=andreip
[email protected]
DELTA=3 (0 added, 0 deleted, 3 changed)
OCL=10212738
Affected files ...
...
//depot/googleclient/gears/opensource/gears/test/testcases/httprequest_tests.js#18
edit
3 delta lines: 0 added, 0 deleted, 3 changed
Also consider running:
g4 lint -c 10212738
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 10212738 by stevebl...@steveblock-gearslinux1 on 2009/02/19 13:24:37
*pending*
Disables testReadyStates for Chrome.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/test/testcases/httprequest_tests.js#18
edit
====
//depot/googleclient/gears/opensource/gears/test/testcases/httprequest_tests.js#18
-
/home/steveblock/GearsLinux1/googleclient/gears/opensource/gears/test/testcases/httprequest_tests.js
====
# action=edit type=text
--- googleclient/gears/opensource/gears/test/testcases/httprequest_tests.js
2009-02-19 13:22:57.000000000 +0000
+++ googleclient/gears/opensource/gears/test/testcases/httprequest_tests.js
2009-02-19 13:23:42.000000000 +0000
@@ -513,9 +513,9 @@
function testReadyStates() {
// Tests that a request goes through all ready states in order.
- if (isFirefox || isSafari || isAndroid) {
- // Firefox, Safari and Android all skip states. Note that this test
- // passes when using the native XmlHttpRequest object on all browsers.
+ if (isFirefox || isSafari || isAndroid || isNPAPI) {
+ // Firefox, Safari, Android and Chrome all skip states. Note that this test
+ // passes when using the native XMLHttpRequest object on all browsers.
// See bug 827.
return;
}
