Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 10244410
or point your web browser to
http://mondrian/10244410
to review the following code:
Change 10244410 by stevebl...@steveblock-gears2 on 2009/02/23 14:09:51 *pending*
Removes the checkbox from the permissions dialog on Opera Mobile.
Mailed on behalf of Opera.
R=andreip
[email protected],[email protected]
DELTA=1 (0 added, 0 deleted, 1 changed)
OCL=10244410
Affected files ...
...
//depot/googleclient/gears/opensource/gears/ui/common/permissions_dialog.html_m4#9
edit
1 delta lines: 0 added, 0 deleted, 1 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 10244410 by stevebl...@steveblock-gears2 on 2009/02/23 14:09:51 *pending*
Removes the checkbox from the permissions dialog on Opera Mobile.
Mailed on behalf of Opera.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/ui/common/permissions_dialog.html_m4#9
edit
====
//depot/googleclient/gears/opensource/gears/ui/common/permissions_dialog.html_m4#9
-
c:\MyDocs\Gears2/googleclient/gears/opensource/gears/ui/common/permissions_dialog.html_m4
====
# action=edit type=text
--- googleclient/gears/opensource/gears/ui/common/permissions_dialog.html_m4
2009-02-23 14:21:56.000000000 +0000
+++ googleclient/gears/opensource/gears/ui/common/permissions_dialog.html_m4
2009-02-23 14:10:19.000000000 +0000
@@ -406,7 +406,7 @@
setTextContent(elem, customMessage);
}
- if (!browser.ie_mobile) {
+ if (!browser.ie_mobile && !(browser.wince && browser.opera)) {
// Set up the checkbox to toggle the enabledness of the Allow button.
dom.getElementById("unlock").onclick = updateAllowButtonEnabledState;
dom.getElementById("checkbox-row").style.display = 'block';
