Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 10316561
or point your web browser to
http://mondrian/10316561
to review the following code:
Change 10316561 by stevebl...@steveblock-gearsosx1 on 2009/02/27 17:40:39
*pending*
Reduces WiFi scanning frequency on OSX to prevent disruption of
connection.
This is required because, unlike on other OSs, we trigger scans rather
than simply reading cached sacn results.
PRESUBMIT=passed
BUG=1605998
R=andreip
[email protected]
DELTA=1 (0 added, 0 deleted, 1 changed)
OCL=10316561
Affected files ...
...
//depot/googleclient/gears/opensource/gears/geolocation/wifi_data_provider_osx.cc#4
edit
1 delta lines: 0 added, 0 deleted, 1 changed
The issue description(s) relevant to this code can be found at:
http://b/issue?id=1605998
or if you are using the old Bugs DB, at:
http://bugs.corp.google.com/show_bug.cgi?id=1605998
Also consider running:
g4 lint -c 10316561
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].