Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 10347104
or point your web browser to
http://mondrian/10347104
to review the following code:
Change 10347104 by stevebl...@steveblock-gears2 on 2009/03/03 10:25:04 *pending*
Modfies dialogs on Opera Mobile to use native, rather than custom
buttons. Mailed on behalf of Opera.
R=andreip
[email protected],[email protected]
DELTA=28 (16 added, 4 deleted, 8 changed)
OCL=10347104
Affected files ...
... //depot/googleclient/gears/opensource/gears/ui/common/html_dialog.js#16 edit
...
//depot/googleclient/gears/opensource/gears/ui/common/permissions_dialog.html_m4#10
edit
...
//depot/googleclient/gears/opensource/gears/ui/common/settings_dialog.html_m4#9
edit
...
//depot/googleclient/gears/opensource/gears/ui/common/shortcuts_dialog.html_m4#11
edit
28 delta lines: 16 added, 4 deleted, 8 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 10347104 by stevebl...@steveblock-gears2 on 2009/03/03 10:25:04 *pending*
Modfies dialogs on Opera Mobile to use native, rather than custom
buttons. Mailed on behalf of Opera.
Affected files ...
... //depot/googleclient/gears/opensource/gears/ui/common/html_dialog.js#16 edit
...
//depot/googleclient/gears/opensource/gears/ui/common/permissions_dialog.html_m4#10
edit
...
//depot/googleclient/gears/opensource/gears/ui/common/settings_dialog.html_m4#9
edit
...
//depot/googleclient/gears/opensource/gears/ui/common/shortcuts_dialog.html_m4#11
edit
==== //depot/googleclient/gears/opensource/gears/ui/common/html_dialog.js#16 -
c:\MyDocs\Gears2/googleclient/gears/opensource/gears/ui/common/html_dialog.js
====
# action=edit type=text
--- googleclient/gears/opensource/gears/ui/common/html_dialog.js
2009-03-03 10:32:16.000000000 +0000
+++ googleclient/gears/opensource/gears/ui/common/html_dialog.js
2009-03-03 10:25:07.000000000 +0000
@@ -29,17 +29,29 @@
function initDialog() {
if (!browser.ie_mobile) {
dom.addEvent(document, "keyup", handleKeyUp);
- } else {
+ }
+
+ if(browser.wince && browser.opera) {
+ initWinCEButtons();
+ }
+
+ if (browser.ie_mobile) {
if (!window.pie_dialog.IsSmartPhone()) {
- var buttonRowElem = dom.getElementById("buttons-wince");
- if (buttonRowElem) {
- buttonRowElem.style.display = 'block';
- }
+ initWinCEButtons();
}
- }
- if (browser.ie_mobile) {
+
window.pie_dialog.SetScriptContext(window);
window.pie_dialog.ResizeDialog();
+ }
+}
+
+/**
+ * Show the WinCE Buttons for IE Mobile and Opera Mobile.
+ */
+function initWinCEButtons() {
+ var buttonRowElem = dom.getElementById("buttons-wince");
+ if (buttonRowElem) {
+ buttonRowElem.style.display = 'block';
}
}
====
//depot/googleclient/gears/opensource/gears/ui/common/permissions_dialog.html_m4#10
-
c:\MyDocs\Gears2/googleclient/gears/opensource/gears/ui/common/permissions_dialog.html_m4
====
# action=edit type=text
--- googleclient/gears/opensource/gears/ui/common/permissions_dialog.html_m4
2009-03-03 10:32:16.000000000 +0000
+++ googleclient/gears/opensource/gears/ui/common/permissions_dialog.html_m4
2009-03-03 10:25:10.000000000 +0000
@@ -229,10 +229,10 @@
~)
</td>
-m4_ifelse(PRODUCT_BROWSER,~IEMOBILE~,m4_dnl
+m4_ifelse(PRODUCT_OS,~wince~,m4_dnl
~ <!--
We use form input buttons instead of button elements as IE Mobile
- does not support them.
+ does not support them and they take up too much space on Opera
Mobile.
-->
<td width="50%" align="right" valign="middle">
====
//depot/googleclient/gears/opensource/gears/ui/common/settings_dialog.html_m4#9
-
c:\MyDocs\Gears2/googleclient/gears/opensource/gears/ui/common/settings_dialog.html_m4
====
# action=edit type=text
--- googleclient/gears/opensource/gears/ui/common/settings_dialog.html_m4
2009-03-03 10:32:16.000000000 +0000
+++ googleclient/gears/opensource/gears/ui/common/settings_dialog.html_m4
2009-03-03 10:25:13.000000000 +0000
@@ -212,7 +212,7 @@
m4_ifelse(PRODUCT_BROWSER,~IEMOBILE~,m4_dnl
~ <!--
We use form input buttons instead of button elements as IE Mobile
- does not support them.
+ does not support them and they take up too much space on Opera
Mobile.
-->
<td width="50%" valign="middle">
====
//depot/googleclient/gears/opensource/gears/ui/common/shortcuts_dialog.html_m4#11
-
c:\MyDocs\Gears2/googleclient/gears/opensource/gears/ui/common/shortcuts_dialog.html_m4
====
# action=edit type=text
--- googleclient/gears/opensource/gears/ui/common/shortcuts_dialog.html_m4
2009-03-03 10:32:16.000000000 +0000
+++ googleclient/gears/opensource/gears/ui/common/shortcuts_dialog.html_m4
2009-03-03 10:25:15.000000000 +0000
@@ -193,10 +193,10 @@
</td>
-m4_ifelse(PRODUCT_BROWSER,~IEMOBILE~,m4_dnl
+m4_ifelse(PRODUCT_OS,~wince~,m4_dnl
~ <!--
We use form input buttons instead of buttons elements as IE Mobile
- does not support them.
+ does not support them and they take up too much space on Opera
Mobile.
-->
<td width="50%" align="right" valign="middle">
