Thanks for the updated patch. I have a few comments below. In particular, I don't think there should be any changes to rules.mk. If you're OK with my suggestions, I'll make them on your behalf and submit.
======================================================================== http://mondrian.corp.google.com/file/9881868///depot/googleclient/gears/opensource/gears/Makefile?a=7 File //depot/googleclient/gears/opensource/gears/Makefile (snapshot 7) ------------------------------------ Line 31: # are not clobbered by the Chrome trickery at the end of the file But the Chrome trickery is only applied when BROWSER=NPAPI (and OS=win32). For the Opera build, BROWSER=OPERA, so this isn't a problem. ------------------------------------ Line 1066: message_queue_cr.cc \ OK, sure. ------------------------------------ Line 1999: opera_local_server_impl.cc \ OK, but it's not yet submitted, so we'll have to remove it for now. We'll add it when we submit the corresponding file. ======================================================================== http://mondrian.corp.google.com/file/9881868///depot/googleclient/gears/opensource/gears/Makefile?a=4 File //depot/googleclient/gears/opensource/gears/Makefile (snapshot 4) ------------------------------------ Line 2360: ifeq ($(OS),wince) We can drop both of these guards. ======================================================================== http://mondrian.corp.google.com/file/9881868///depot/googleclient/gears/opensource/gears/Makefile?a=7 File //depot/googleclient/gears/opensource/gears/Makefile (snapshot 7) ------------------------------------ Line 2366: ifeq ($(OS),win32) Maybe add a comment that we use this guard to avoid clobbering NPAPI_XXX for other builds? ======================================================================== http://mondrian.corp.google.com/file/9881868///depot/googleclient/gears/opensource/gears/tools/config.mk?a=7 File //depot/googleclient/gears/opensource/gears/tools/config.mk (snapshot 7) ------------------------------------ Line 758: ec...@echo Why remove the dot? ======================================================================== http://mondrian.corp.google.com/file/9881868///depot/googleclient/gears/opensource/gears/tools/config.mk?a=1 File //depot/googleclient/gears/opensource/gears/tools/config.mk (snapshot 1) ------------------------------------ Line 927: OPERA_LIBS = delayimp.lib /DELAYLOAD:"comdlg32.dll" comdlg32.lib Sorry, I think I misread this the first time round. If these NPAPI_LIBS aren't needed on WinCE, we should remove them using the if ... else. ======================================================================== http://mondrian.corp.google.com/file/9881868///depot/googleclient/gears/opensource/gears/tools/rules.mk?a=4 File //depot/googleclient/gears/opensource/gears/tools/rules.mk (snapshot 4) ------------------------------------ Line 440: # desktop. Let's leave this in until we have Gears for Opera desktop ready to go. ======================================================================== http://mondrian.corp.google.com/file/9881868///depot/googleclient/gears/opensource/gears/tools/rules.mk?a=7 File //depot/googleclient/gears/opensource/gears/tools/rules.mk (snapshot 7) ------------------------------------ Line 855: $(shell $(GGUIDGEN) $(NAMESPACE_GUID) OUR_COMPONENT_GUID_OPERA_FILES-$(VERSION)) Win32 ------------------------------------ Line 889: -dOurComponentGUID_OperaFiles=$(OUR_COMPONENT_GUID_OPERA_FILES) \ Win32 ======================================================================== -- To respond, reply to this email or visit http://mondrian.corp.google.com/9881868
