Hello noel,
I'd like you to do a code review. Please execute
g4 diff -c 10377478
or point your web browser to
http://mondrian/10377478
to review the following code:
Change 10377478 by nigel...@nigeltao-srcgears2 on 2009/03/05 20:16:32 *pending*
Make desktop.getDragData(...) accept 'application/x-gears-files'
as well as just 'Files'.
PRESUBMIT=passed
R=noel
[email protected]
DELTA=5 (4 added, 0 deleted, 1 changed)
OCL=10377478
Affected files ...
... //depot/googleclient/gears/opensource/gears/desktop/desktop.cc#81 edit
5 delta lines: 4 added, 0 deleted, 1 changed
Also consider running:
g4 lint -c 10377478
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 10377478 by nigel...@nigeltao-srcgears2 on 2009/03/05 20:16:32 *pending*
Make desktop.getDragData(...) accept 'application/x-gears-files'
as well as just 'Files'.
Affected files ...
... //depot/googleclient/gears/opensource/gears/desktop/desktop.cc#81 edit
==== //depot/googleclient/gears/opensource/gears/desktop/desktop.cc#81 -
/home/nigeltao/srcgears2/googleclient/gears/opensource/gears/desktop/desktop.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/desktop/desktop.cc 2009-03-03
17:05:38.000000000 +1100
+++ googleclient/gears/opensource/gears/desktop/desktop.cc 2009-03-05
20:16:02.000000000 +1100
@@ -925,7 +925,11 @@
// TODO(nigeltao): Should "Files" be case (in)sensitive? Or should it be
// something like "GearsFiles" or "application/x-gears-files"?
DragAndDropFlavorType flavor = DRAG_AND_DROP_FLAVOR_INVALID;
- if (flavor_as_string == STRING16(L"Files")) {
+ if (flavor_as_string == STRING16(L"application/x-gears-files")) {
+ flavor = DRAG_AND_DROP_FLAVOR_FILES;
+ } else if (flavor_as_string == STRING16(L"Files")) {
+ // TODO(nigeltao): Remove "Files" as an option, we should probably just
+ // stick with "application/x-gears-files" for now.
flavor = DRAG_AND_DROP_FLAVOR_FILES;
}
if (flavor == DRAG_AND_DROP_FLAVOR_INVALID) {
