LGTM Note the bugfix below before submitting.
======================================================================== http://mondrian.corp.google.com/file/10345804///depot/googleclient/gears/opensource/gears/canvas/canvas_rendering_context_2d.cc?a=1 File //depot/googleclient/gears/opensource/gears/canvas/canvas_rendering_context_2d.cc (snapshot 1) ------------------------------------ Line 45: fill_style_as_string_(STRING16(L"#000000")), Whatever initial state the canvas has on day 1, callers will come to rely on (i.e. assume) those initial values. Are the values here standardized? Does Canvas spec this? Just curious. ------------------------------------ Line 230: skia_canvas_->rotate(SkDoubleToScalar(angle * 180.0 / 3.1415926535)); Is there no constant for Pi in any header?? ------------------------------------ Line 270: if (reset_matrix) { I think you got these two cases reversed? ======================================================================== -- To respond, reply to this email or visit http://mondrian.corp.google.com/10345804
