Hello andreip, nigeltao,
I'd like you to do a code review. Please execute
g4 diff -c 10394217
or point your web browser to
http://mondrian/10394217
to review the following code:
Change 10394217 by stevebl...@steveblock-gears3 on 2009/03/06 12:14:52 *pending*
Fixes build bustage - Drag-and-Drop API is only supported in
non-official builds and on certain platforms.
R=andreip,nigeltao
[email protected]
DELTA=11 (11 added, 0 deleted, 0 changed)
OCL=10394217
Affected files ...
...
//depot/googleclient/gears/opensource/gears/desktop/meta_data_extraction.cc#1
edit
11 delta lines: 11 added, 0 deleted, 0 changed
Also consider running:
g4 lint -c 10394217
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 10394217 by stevebl...@steveblock-gears3 on 2009/03/06 12:14:52 *pending*
Fixes build bustage - Drag-and-Drop API is only supported in
non-official builds and on certain platforms.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/desktop/meta_data_extraction.cc#1
edit
====
//depot/googleclient/gears/opensource/gears/desktop/meta_data_extraction.cc#1 -
c:\MyDocs\Gears3/googleclient/gears/opensource/gears/desktop/meta_data_extraction.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/desktop/meta_data_extraction.cc
2009-03-06 12:21:28.000000000 +0000
+++ googleclient/gears/opensource/gears/desktop/meta_data_extraction.cc
2009-03-06 12:13:34.000000000 +0000
@@ -23,6 +23,14 @@
// OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
// ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+#ifdef OFFICIAL_BUILD
+ // The Drag-and-Drop API has not been finalized for official builds.
+#else
+
+#include "gears/desktop/drop_target_base.h"
+
+#if GEARS_DRAG_AND_DROP_API_IS_SUPPORTED_FOR_THIS_PLATFORM
+
#include "gears/desktop/meta_data_extraction.h"
#include "gears/base/common/js_types.h"
@@ -264,3 +272,6 @@
std::string16(STRING16(L"mimeType")),
std::string16(STRING16(L"application/octet-stream")));
}
+
+#endif // GEARS_DRAG_AND_DROP_API_IS_SUPPORTED_FOR_THIS_PLATFORM
+#endif // OFFICIAL_BUILD
