LGTM ======================================================================== http://mondrian.corp.google.com/file/10378334///depot/googleclient/gears/opensource/gears/geolocation/device_data_provider.h?a=1 File //depot/googleclient/gears/opensource/gears/geolocation/device_data_provider.h (snapshot 1) ------------------------------------ Line 147: bool operator<(const AccessPointData &other) const { In its wisdom, the style guide says this is a no no:
"In particular, do not overload operator== or operator< just so that your class can be used as a key in an STL container; instead, you should create equality and comparison functor types when declaring the container." ======================================================================== -- To respond, reply to this email or visit http://mondrian.corp.google.com/10378334
