Hello andreip, michaeln,
I'd like you to do a code review. Please execute
g4 diff -c 10574036
or point your web browser to
http://mondrian/10574036
to review the following code:
Change 10574036 by nicolasro...@nicolasroard-tangerine-gears3 on 2009/03/23
19:49:26 *pending*
Fix thread leaking.
We sometimes ignored final transitions, preventing us to destroy the
thread.
PRESUBMIT=passed
R=andreip,michaeln
[email protected]
DELTA=26 (7 added, 14 deleted, 5 changed)
OCL=10574036
Affected files ...
...
//depot/googleclient/gears/opensource/gears/localserver/android/http_request_android.cc#13
edit
...
//depot/googleclient/gears/opensource/gears/localserver/android/http_request_android.h#7
edit
26 delta lines: 7 added, 14 deleted, 5 changed
Also consider running:
g4 lint -c 10574036
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
