======================================================================== http://mondrian.corp.google.com/file/10562599///depot/googleclient/gears/opensource/gears/canvas/canvas_rendering_element_ie.cc?a=2 File //depot/googleclient/gears/opensource/gears/canvas/canvas_rendering_element_ie.cc (snapshot 2) ------------------------------------ Line 60: paint_site_ = pElementBehaviorSite; There's an implicit QI here because paint_site_ is a CComQIPtr<>. Test the result of that implicit QI and respond accordingly. ------------------------------------ Line 189: document->createElement(CComBSTR(STRING16(L"gearsCanvasRenderer")), &result); Is the STRING16() really needed here? ------------------------------------ Line 192: return NULL; do we leak result here? and so on for each of the return NULL cases below? ------------------------------------ Line 205: html_element_ = result; again, and inplicit QI here -- should html_element_ just be a CComPtr<>, and how would that help? ========================================================================
-- To respond, reply to this email or visit http://mondrian.corp.google.com/10562599
