========================================================================
http://mondrian.corp.google.com/file/10579925///depot/googleclient/gears/opensource/gears/blob/blob_builder_module.cc?a=2
File //depot/googleclient/gears/opensource/gears/blob/blob_builder_module.cc
(snapshot 2)
------------------------------------
Line 75: } else if (type == JSPARAM_OBJECT) {
On 25 Mar, michaeln wrote:
> There's some FUD around the distinction between JSPARAM_OBJECT and
> JSPARAM_MODULE. Maybe accept either value in this test?
Done.
------------------------------------
Line 97: if (array_stack == NULL) {
On 25 Mar, michaeln wrote:
> You still may be able to stick more exlusively to higher level APIs by using
> JsArray.GetElementType() and JsArray.GetElementAsXXX()?
Possibly, but that won't necessarily be any less ugly.
------------------------------------
Line 117: !Append(array_element, js_context, array_stack)) {
On 25 Mar, michaeln wrote:
> There's one significant issue with the new Append behavior. If the caller
passes
> in an array with a bunch of valid elements but has some undefined or illegal
> element types interspersed in there... Append will return false, but will have
> appended some stuff.
>
> I think if the method fails, nothing should have been appended... all or none.
Done. Append is now atomic wrt arrays.
========================================================================
--
To respond, reply to this email or visit
http://mondrian.corp.google.com/10579925
