Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 10704896
or point your web browser to
http://mondrian/10704896
to review the following code:
Change 10704896 by stevebl...@steveblock-gears1 on 2009/04/03 10:13:49 *pending*
Fix for Issue 856 - fixes links and file names in Gears tutorial.
Is there a reason that the tutorial suggested renaming
tutorial_manifest.json?
R=andreip
[email protected]
DELTA=8 (1 added, 1 deleted, 6 changed)
OCL=10704896
Affected files ...
... //depot/googleclient/gears/opensource/gears/sdk/tutorial.html#2 edit
8 delta lines: 1 added, 1 deleted, 6 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 10704896 by stevebl...@steveblock-gears1 on 2009/04/03 10:13:49 *pending*
Fix for Issue 856 - fixes links and file names in Gears tutorial.
Affected files ...
... //depot/googleclient/gears/opensource/gears/sdk/tutorial.html#2 edit
==== //depot/googleclient/gears/opensource/gears/sdk/tutorial.html#2 -
c:\MyDocs\Gears1/googleclient/gears/opensource/gears/sdk/tutorial.html ====
# action=edit type=text
--- googleclient/gears/opensource/gears/sdk/tutorial.html 2009-04-03
11:20:01.000000000 +0100
+++ googleclient/gears/opensource/gears/sdk/tutorial.html 2009-04-03
11:16:59.000000000 +0100
@@ -56,8 +56,7 @@
<h1>1. Edit the sample manifest file </h1>
<h3>Save this <a href="tutorials/tutorial_manifest.json">tutorial manifest
file</a> to your computer. </h3>
<ul>
- <li>Rename it "manifest.json". </li>
- <li>Open your <strong>manifest.json</strong> in an editor.</li>
+ <li>Open your <strong>tutorial_manifest.json</strong> in an editor.</li>
</ul>
<h3>Edit the version value </h3>
<p>The manifest file contains a series of attribute-value pairs. </p>
@@ -90,7 +89,8 @@
<a href="gears_init.js">gears_init.js</a> - provides access to Gears. </p>
<p><strong><em>Special note:</em></strong> To keep this tutorial simple, the
go_offline.html file is provided to act as the user interface.</p>
<p>You are not limited to using the provided file; you can integrate the
functionality provided in the go_offline.js JavaScript file into your
application in other ways. </p>
-<p>Keep in mind that the user will need to:</p>
+<p>Note that go_offline.html expects gears_init.js to be in the parent
directory. If you have downloaded all files to the same location, you will need
to edit go_offline.html accordingly.</p>
+<p>Keep in mind that the user will need to:</p>
<ul>
<li>Install Gears</li>
<li>Allow your website to use Gears (a permissions dialog appears
automatically) </li>
@@ -102,8 +102,8 @@
<li>go_offline.html</li>
<li>go_offline.js</li>
<li>gears_init.js</li>
- <li>manifest.json</li>
- <li>All the files listed in your manifest.json file.</li>
+ <li>tutorial_manifest.json</li>
+ <li>All the files listed in your tutorial_manifest.json file.</li>
</ul>
<p><strong>Important:</strong> Be sure all the files listed in the manifest
file are available and accessible as listed. </p>
<h1>4. Test: capture the files locally </h1>
@@ -132,8 +132,8 @@
<ul>
<li>Make sure you have installed Gears. </li>
<li>All the URLs in the manifest file must be correct, and reachable from
the directory that the manifest resides in. The manifest file and the URLs it
references must be located in the same domain. </li>
- <li>Check that there aren't any typos or extraneous files listed in the
manifest.</li>
- <li>The code in <strong>go_offline.js</strong> expects that the manifest
file is named "manifest.json" and that it resides in the same
directory. Update the manifest.json references in go_offline.js as needed. </li>
+ <li>Check that there aren't any typos or extraneous files listed in the
manifest.</li>
+ <li>Make sure that go_offline.html includes gears_init.js from the correct
location.</li>
<li>Use a JavaScript debugger to see any errors that may be returned from
the Gears API calls. </li>
</ul>
<h1>6. Publish it to your users</h1>
