Hello noel,
I'd like you to do a code review. Please execute
g4 diff -c 10934821
or point your web browser to
http://mondrian/10934821
to review the following code:
Change 10934821 by nigel...@nigeltao-srcgears5 on 2009/04/27 17:28:49 *pending*
Implement maximal bounds for canvas's decode, crop, resize, setWidth
and setHeight.
PRESUBMIT=passed
R=noel
[email protected]
DELTA=56 (49 added, 5 deleted, 2 changed)
OCL=10934821
Affected files ...
... //depot/googleclient/gears/opensource/gears/canvas/canvas.cc#29 edit
... //depot/googleclient/gears/opensource/gears/canvas/canvas.h#23 edit
56 delta lines: 49 added, 5 deleted, 2 changed
Also consider running:
g4 lint -c 10934821
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
