LGTM before (still LGTM now based on the comments, not looking at the .h file:)
BTW, since we now bundle gears with chrome and don't update them independently, the versioning in this API is a lot less important, mostly useful for throwing debug builds around... but strictly speaking, you should check for their presence prior to calling these new CPAPI functions from the gears side. On Tue, Apr 28, 2009 at 9:47 PM, Noel Gordon <[email protected]> wrote: > ======================================================================== > http://mondrian.corp.google.com/file/10947778///depot/googleclient/gears/opensource/third_party/chrome/chrome_plugin_api.h?a=1 > File > //depot/googleclient/gears/opensource/third_party/chrome/chrome_plugin_api.h > (snapshot 1) > ------------------------------------ > Line 460: uint32* identity, uint32* event_id, char** drag_type, char** > drag_data); > ok, int32 for both then. looks ok? > ======================================================================== > > -- > To respond, reply to this email or visit > http://mondrian.corp.google.com/10947778 >
