Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 10994825
or point your web browser to
http://mondrian/10994825
to review the following code:
Change 10994825 by stevebl...@steveblock-gears4 on 2009/05/01 13:41:37 *pending*
Updates Geolocation default network location provider
(www.corp.google.com/loc/json) to use HTTPS.
This has been tested on several Windows Mobile devices, but more
thorough testing will be required before release.
R=andreip
[email protected]
DELTA=1 (0 added, 0 deleted, 1 changed)
OCL=10994825
Affected files ...
... //depot/googleclient/gears/opensource/gears/geolocation/geolocation.cc#77
edit
1 delta lines: 0 added, 0 deleted, 1 changed
Also consider running:
g4 lint -c 10994825
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 10994825 by stevebl...@steveblock-gears4 on 2009/05/01 13:41:37 *pending*
Updates Geolocation default network location provider
(www.corp.google.com/loc/json) to use HTTPS.
This has been tested on several Windows Mobile devices, but more
thorough testing will be required before release.
Affected files ...
... //depot/googleclient/gears/opensource/gears/geolocation/geolocation.cc#77
edit
==== //depot/googleclient/gears/opensource/gears/geolocation/geolocation.cc#77
-
c:\MyDocs\Gears4/googleclient/gears/opensource/gears/geolocation/geolocation.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/geolocation/geolocation.cc
2009-05-01 15:38:32.000000000 +0100
+++ googleclient/gears/opensource/gears/geolocation/geolocation.cc
2009-05-01 13:40:07.000000000 +0100
@@ -50,7 +50,7 @@
#include "gears/geolocation/geolocation_db.h"
static const char16 *kDefaultLocationProviderUrl =
- STRING16(L"http://www.google.com/loc/json";);
+ STRING16(L"https://www.google.com/loc/json";);
// API options constants.
static const char16 *kEnableHighAccuracy = STRING16(L"enableHighAccuracy");
