======================================================================== http://mondrian.corp.google.com/file/11153982///depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ie.cc?a=1 File //depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ie.cc (snapshot 1) ------------------------------------ Line 42: path_[0] = static_cast<WCHAR>(0); // assumption: path_[MAX_PATH] Can you clarify what the assumption is here? Is it that path_[MAX_PATH] != (WCHAR)0? ------------------------------------ Line 46: bool Found() const { Would IsCopyable be a better name than IsFound? ------------------------------------ Line 56: ULONGLONG GetFileSize() const { I would leave this method out, if it isn't used. ------------------------------------ Line 62: const WCHAR *GetBaseName() const { I would leave this method out, if it isn't used. ------------------------------------ Line 66: const WCHAR *GetFileExtension() const { I would leave this method out, if it isn't used. ------------------------------------ Line 106: LOG16((L" link resolve failed\n")); Do we need to call ::FindClose in this branch? What if the opening (attributes_ & SFGAO_LINK) test fails? When do we call ::FindClose? ========================================================================
-- To respond, reply to this email or visit http://mondrian.corp.google.com/11153982
