Hello noel,
I'd like you to do a code review. Please execute
g4 diff -c 11169785
or point your web browser to
http://mondrian/11169785
to review the following code:
Change 11169785 by nigel...@nigeltao-srcgears5 on 2009/05/18 16:34:09 *pending*
Desktop.getDragData now only takes "application/x-gears-files", not
"Files".
PRESUBMIT=passed
R=noel
[email protected]
DELTA=8 (0 added, 6 deleted, 2 changed)
OCL=11169785
Affected files ...
... //depot/googleclient/gears/opensource/gears/desktop/desktop.cc#88 edit
8 delta lines: 0 added, 6 deleted, 2 changed
Also consider running:
g4 lint -c 11169785
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 11169785 by nigel...@nigeltao-srcgears5 on 2009/05/18 16:34:09 *pending*
Desktop.getDragData now only takes "application/x-gears-files", not
"Files".
Affected files ...
... //depot/googleclient/gears/opensource/gears/desktop/desktop.cc#88 edit
==== //depot/googleclient/gears/opensource/gears/desktop/desktop.cc#88 -
/home/nigeltao/srcgears5/googleclient/gears/opensource/gears/desktop/desktop.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/desktop/desktop.cc 2009-05-18
16:34:16.000000000 +1000
+++ googleclient/gears/opensource/gears/desktop/desktop.cc 2009-05-18
16:29:58.000000000 +1000
@@ -908,16 +908,10 @@
context->GetArguments(ARRAYSIZE(argv), argv);
if (context->is_exception_set()) return;
- // Currently, we only support one flavor: "Files". In the future, we may
- // support others, such as "Text" or "URL".
- // TODO(nigeltao): Should "Files" be case (in)sensitive? Or should it be
- // something like "GearsFiles" or "application/x-gears-files"?
+ // Currently, we only support one flavor: "application/x-gears-files". In the
+ // future, we may support others, such as "Text" or "URL".
DragAndDropFlavorType flavor = DRAG_AND_DROP_FLAVOR_INVALID;
if (flavor_as_string == STRING16(L"application/x-gears-files")) {
- flavor = DRAG_AND_DROP_FLAVOR_FILES;
- } else if (flavor_as_string == STRING16(L"Files")) {
- // TODO(nigeltao): Remove "Files" as an option, we should probably just
- // stick with "application/x-gears-files" for now.
flavor = DRAG_AND_DROP_FLAVOR_FILES;
}
if (flavor == DRAG_AND_DROP_FLAVOR_INVALID) {
