Hello noel,
I'd like you to do a code review. Please execute
g4 diff -c 11172385
or point your web browser to
http://mondrian/11172385
to review the following code:
Change 11172385 by nigel...@nigeltao-srcgears2 on 2009/05/19 00:14:07 *pending*
Remove unused AcceptDrag function from the header (we have previously
removed it from the .cc file).
PRESUBMIT=passed
R=noel
[email protected]
DELTA=11 (0 added, 11 deleted, 0 changed)
OCL=11172385
Affected files ...
... //depot/googleclient/gears/opensource/gears/desktop/desktop.h#32 edit
11 delta lines: 0 added, 11 deleted, 0 changed
Also consider running:
g4 lint -c 11172385
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 11172385 by nigel...@nigeltao-srcgears2 on 2009/05/19 00:14:07 *pending*
Remove unused AcceptDrag function from the header (we have previously
removed it from the .cc file).
Affected files ...
... //depot/googleclient/gears/opensource/gears/desktop/desktop.h#32 edit
==== //depot/googleclient/gears/opensource/gears/desktop/desktop.h#32 -
/home/nigeltao/srcgears2/googleclient/gears/opensource/gears/desktop/desktop.h
====
# action=edit type=text
--- googleclient/gears/opensource/gears/desktop/desktop.h 2009-05-12
13:57:30.000000000 +1000
+++ googleclient/gears/opensource/gears/desktop/desktop.h 2009-05-19
00:13:33.000000000 +1000
@@ -172,17 +172,6 @@
void OpenFiles(JsCallContext *context);
#if GEARS_DRAG_AND_DROP_API_IS_SUPPORTED_FOR_THIS_PLATFORM
- // TODO(nigeltao): decide which of AcceptDrag and SetDragCursor to
- // keep and which to cull, since they essentially do the same thing (except
- // that AcceptDrag takes responsibility for calling event.cancelBubble(true),
- // event.returnValue=false, event.dataTransfer.dropEffect="copy", whereas
- // the SetDragCursor model only does the latter of those three, and puts
- // the onus for the first two on the web-app (rather than Gears)).
-
- // IN: Event event, bool acceptance
- // OUT: -
- void AcceptDrag(JsCallContext *context);
-
// IN: GearsBlob blob
// OUT: object metadata
void ExtractMetaData(JsCallContext *context);
