Hello noel,
I'd like you to do a code review. Please execute
g4 diff -c 11186615
or point your web browser to
http://mondrian/11186615
to review the following code:
Change 11186615 by nigel...@nigeltao-srcgears2 on 2009/05/19 19:00:19 *pending*
Remove obsolete comment.
PRESUBMIT=passed
R=noel
[email protected]
DELTA=2 (0 added, 2 deleted, 0 changed)
OCL=11186615
Affected files ...
...
//depot/googleclient/gears/opensource/gears/canvas/canvas_rendering_context_2d.h#19
edit
2 delta lines: 0 added, 2 deleted, 0 changed
Also consider running:
g4 lint -c 11186615
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 11186615 by nigel...@nigeltao-srcgears2 on 2009/05/19 19:00:19 *pending*
Remove obsolete comment.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/canvas/canvas_rendering_context_2d.h#19
edit
====
//depot/googleclient/gears/opensource/gears/canvas/canvas_rendering_context_2d.h#19
-
/home/nigeltao/srcgears2/googleclient/gears/opensource/gears/canvas/canvas_rendering_context_2d.h
====
# action=edit type=text
--- googleclient/gears/opensource/gears/canvas/canvas_rendering_context_2d.h
2009-05-19 19:00:29.000000000 +1000
+++ googleclient/gears/opensource/gears/canvas/canvas_rendering_context_2d.h
2009-05-19 18:59:04.000000000 +1000
@@ -221,8 +221,6 @@
scoped_refptr<GearsCanvas> gears_canvas_;
scoped_ptr<SkCanvas> skia_canvas_;
- // TODO(nigeltao): Introduce a class to capture the {SkPaint, SkColor,
- // std::string16} for both the fill and the stroke.
SkPaint clear_style_as_paint_;
Style fill_style_;
Style stroke_style_;
