Hello michaeln,
I'd like you to do a code review. Please execute
g4 diff -c 11398305
or point your web browser to
http://mondrian/11398305
to review the following code:
Change 11398305 by nigel...@nigeltao-srcwingears2 on 2009/06/05 14:41:38
*pending*
In base/firefox/dom_utils.cc's WIN32 code, replace E_FAIL by
NS_ERROR_FAILURE, since the surrounding method returns an
XPCOM result code, not a COM result code.
Trivia -- these constants have the same value (0x80004005L),
since the XPCOM designers presumably just copied COM here.
R=michaeln
[email protected]
DELTA=1 (0 added, 0 deleted, 1 changed)
OCL=11398305
Affected files ...
... //depot/googleclient/gears/opensource/gears/base/firefox/dom_utils.cc#9 edit
1 delta lines: 0 added, 0 deleted, 1 changed
Also consider running:
g4 lint -c 11398305
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 11398305 by nigel...@nigeltao-srcwingears2 on 2009/06/05 14:41:38
*pending*
In base/firefox/dom_utils.cc's WIN32 code, replace E_FAIL by
NS_ERROR_FAILURE, since the surrounding method returns an
XPCOM result code, not a COM result code.
Trivia -- these constants have the same value (0x80004005L),
since the XPCOM designers presumably just copied COM here.
OCL=11398305
Affected files ...
... //depot/googleclient/gears/opensource/gears/base/firefox/dom_utils.cc#9 edit
==== //depot/googleclient/gears/opensource/gears/base/firefox/dom_utils.cc#9 -
c:\devel\srcwingears2/googleclient/gears/opensource/gears/base/firefox/dom_utils.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/base/firefox/dom_utils.cc
2009-06-05 14:41:49.000000000 +1000
+++ googleclient/gears/opensource/gears/base/firefox/dom_utils.cc
2009-06-05 14:38:53.000000000 +1000
@@ -193,7 +193,7 @@
nsCOMPtr<nsIWidget> widget;
nr = baseWindow->GetMainWidget(getter_AddRefs(widget));
if (NS_FAILED(nr)) { return nr; }
- if (!widget) { return E_FAIL; }
+ if (!widget) { return NS_ERROR_FAILURE; }
*window = reinterpret_cast<NativeWindowPtr>(
widget->GetNativeData(NS_NATIVE_WINDOW));
