Hello noel,
I'd like you to do a code review. Please execute
g4 diff -c 13535083
or point your web browser to
http://mondrian/13535083
to review the following code:
Change 13535083 by nigel...@nigeltao-srcgears1 on 2009/11/12 14:28:06 *pending*
API documentation updates for canvas.rotate and Exif orientation.
PRESUBMIT=passed
R=noel
[email protected]
DELTA=76 (75 added, 0 deleted, 1 changed)
OCL=13535083
Affected files ...
... //depot/googleclient/gears/opensource/gears/sdk/api_canvas.html#2 edit
... //depot/googleclient/gears/opensource/gears/sdk/api_desktop.html#11 edit
76 delta lines: 75 added, 0 deleted, 1 changed
Also consider running:
g4 lint -c 13535083
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 13535083 by nigel...@nigeltao-srcgears1 on 2009/11/12 14:28:06 *pending*
API documentation updates for canvas.rotate and Exif orientation.
Affected files ...
... //depot/googleclient/gears/opensource/gears/sdk/api_canvas.html#2 edit
... //depot/googleclient/gears/opensource/gears/sdk/api_desktop.html#11 edit
==== //depot/googleclient/gears/opensource/gears/sdk/api_canvas.html#2 -
/home/nigeltao/srcgears1/googleclient/gears/opensource/gears/sdk/api_canvas.html
====
# action=edit type=text
--- googleclient/gears/opensource/gears/sdk/api_canvas.html 2009-11-12
14:27:07.000000000 +1100
+++ googleclient/gears/opensource/gears/sdk/api_canvas.html 2009-11-11
16:25:11.000000000 +1100
@@ -83,7 +83,12 @@
void <b>crop</b>(x, y, w, h)
void <b>decode</b>(blob)
Blob <b>encode</b>([mimeType, options])
+void <b>flipHorizontal</b>()
+void <b>flipVertical</b>()
void <b>resize</b>(w, h, [filter])
+void <b>rotate180</b>()
+void <b>rotateCW</b>()
+void <b>rotateCCW</b>()
</code></pre>
<br>
@@ -186,6 +191,32 @@
<tr class="odd">
<td>Return value:</td>
<td>A new Blob encoding the Canvas' image data.</td>
+ </tr>
+</table>
+
+<table>
+ <tr class="odd">
+ <th colspan="2"><code>void flipHorizontal()</code></th>
+ </tr>
+ <tr class="odd">
+ <td width="113">Summary:</td>
+ <td width="550" class="odd">
+ Flips the Canvas horizontally. The resize happens "in-place",
+ as opposed to returning a new Canvas.
+ </td>
+ </tr>
+</table>
+
+<table>
+ <tr class="odd">
+ <th colspan="2"><code>void flipVertical()</code></th>
+ </tr>
+ <tr class="odd">
+ <td width="113">Summary:</td>
+ <td width="550" class="odd">
+ Flips the Canvas vertically. The resize happens "in-place",
+ as opposed to returning a new Canvas.
+ </td>
</tr>
</table>
@@ -216,6 +247,45 @@
</tr>
</table>
+<table>
+ <tr class="odd">
+ <th colspan="2"><code>void rotate180()</code></th>
+ </tr>
+ <tr class="odd">
+ <td width="113">Summary:</td>
+ <td width="550" class="odd">
+ Rotates the Canvas by 180 degrees. The resize happens
+ "in-place", as opposed to returning a new Canvas.
+ </td>
+ </tr>
+</table>
+
+<table>
+ <tr class="odd">
+ <th colspan="2"><code>void rotateCW()</code></th>
+ </tr>
+ <tr class="odd">
+ <td width="113">Summary:</td>
+ <td width="550" class="odd">
+ Rotates the Canvas clockwise by 90 degrees. The resize happens
+ "in-place", as opposed to returning a new Canvas.
+ </td>
+ </tr>
+</table>
+
+<table>
+ <tr class="odd">
+ <th colspan="2"><code>void rotateCCW()</code></th>
+ </tr>
+ <tr class="odd">
+ <td width="113">Summary:</td>
+ <td width="550" class="odd">
+ Rotates the Canvas counter-clockwise by 90 degrees. The resize happens
+ "in-place", as opposed to returning a new Canvas.
+ </td>
+ </tr>
+</table>
+
</div>
</body>
==== //depot/googleclient/gears/opensource/gears/sdk/api_desktop.html#11 -
/home/nigeltao/srcgears1/googleclient/gears/opensource/gears/sdk/api_desktop.html
====
# action=edit type=text
--- googleclient/gears/opensource/gears/sdk/api_desktop.html 2009-11-12
14:27:07.000000000 +1100
+++ googleclient/gears/opensource/gears/sdk/api_desktop.html 2009-11-12
14:26:51.000000000 +1100
@@ -180,7 +180,7 @@
<tr class="odd">
<td>Return value:</td>
<td class="odd">
- A JavaScript Object (i.e. a key-value map). Currently, three keys are
+ A JavaScript Object (i.e. a key-value map). Currently, four keys are
provided (although all keys are optional -- no key is guaranteed to be
present on all Blobs):
<ul>
@@ -190,6 +190,11 @@
<li>"imageWidth", only defined for Blobs that contain image
data, will have an integer value that is the width of that image.
<li>"imageHeight" is similar to "imageWidth".
+ <li>"exifOrientation", only defined for Blobs that contain
+ JPEG image data that have Exif metadata. The value is an integer
+ between 1 and 8 (inclusive), as per the
+ <a href="http://www.exif.org/Exif2-2.PDF";>Exif 2.2 specification</a>
+ (section 4.6.4.A under "Orientation").
</ul>
</td>
</tr>
