On Fri, Jan 15, 2010 at 4:27 PM, Aaron Boodman <[email protected]> wrote:
> ======================================================================== > > http://mondrian.corp.google.com/file/14259259///depot/googleclient/gears/opensource/gears/base/firefox/static_files/components/stub.js?a=1 > File > //depot/googleclient/gears/opensource/gears/base/firefox/static_files/components/stub.js > (snapshot 1) > ------------------------------------ > Line 58: return "ff36"; > woot. > ======================================================================== > > http://mondrian.corp.google.com/file/14259259///depot/googleclient/gears/opensource/gears/tools/config.mk?a=1 > File //depot/googleclient/gears/opensource/gears/tools/config.mk (snapshot > 1) > ------------------------------------ > Line 225: ifeq ($(BROWSER),FF2) > We should remove FF2 now. How hard would that be? > 1-2 days to remove with proper testing. > ------------------------------------ > Line 752: FF36_LIBS += $(GECKO_SDK)/gecko_sdk/lib/XUL > $(GECKO_SDK)/gecko_sdk/lib/libxpcomglue_s.a > trailing whitespace. > Fixed. ======================================================================== > > http://mondrian.corp.google.com/file/14259259///depot/googleclient/gears/opensource/gears/tools/rules.mk?a=1 > File //depot/googleclient/gears/opensource/gears/tools/rules.mk (snapshot > 1) > ------------------------------------ > Line 1220: # $(FF2_MODULE_DLL) $(FF3_MODULE_DLL) $(FF31_MODULE_DLL) > $(FF36_MODULE_DLL) $(FF36_MODULE_TYPELIB) $(FF36_RESOURCES) > $(FF36_M4FILES_I18N) $(FF36_OUTDIR)/genfiles/chrome.manifest > Don't we need FF31_MODULE_TYPELIB > There's only one FFX_MODULE_TYPELIB. I updated it to use FF36. > ======================================================================== > > -- > To respond, reply to this email or visit > http://mondrian.corp.google.com/14259259 > >
