Hi Guys,

I already saw that you changed the instruction for external
contributors. I think this paragraph is still not very clear:


        git diff is the best way to do this. Please don't send modified
        source files (i.e. "GearyApplication.vala"), this is not a good
        way to deliver a patch to us. To generate a patch from a branch,
        first make sure that you've checked in your code (see above.)
        Now create a diff against the master branch:


I think this version is better, short and clear:


        To submit a patch as an external developer (not in the yorba
        team), use git diff. Post the output of the command as a comment
        to the bug. After review, we will add the patch to the
        repository. For external developers it is not yet possible to
        submit a patch via git push.


If you want want to write it in particular that developers shouldn't
post the whole file write something like this (the above confused me a
lot):


        Please also don't send us the whole source file, the diff
        command will output only the changes - that's enough. 
        

cheers
meles
_______________________________________________
Geary mailing list
[email protected]
http://lists.yorba.org/cgi-bin/mailman/listinfo/geary

Reply via email to