jonnybot0 commented on code in PR #196:
URL: https://github.com/apache/groovy-geb/pull/196#discussion_r1866617506
##########
module/geb-core/src/main/groovy/geb/module/DateTimeLocalInput.groovy:
##########
@@ -15,18 +15,44 @@
*/
package geb.module
+import groovy.util.logging.Slf4j
+
import java.time.LocalDateTime
+import java.time.format.DateTimeFormatter
+import java.time.format.DateTimeFormatterBuilder
+
+import static java.time.temporal.ChronoField.*
+@Slf4j
class DateTimeLocalInput extends AbstractInput {
+ /* codenarc-disable */
Review Comment:
Final nit: let's disable the specific rules we need to disable:
```
// codenarc-disable DuplicateNumberLiteral
// codenarc-disable DuplicateStringLiteral
```
Do that, and you're good to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]