Vampire commented on code in PR #267:
URL: https://github.com/apache/groovy-geb/pull/267#discussion_r2060882411
##########
module/geb-core/src/main/groovy/geb/test/GebTestManager.groovy:
##########
@@ -97,6 +97,11 @@ class GebTestManager {
this.testClass.get().push(testClass)
currentTestName.set(testName)
if (reportingEnabled) {
+ // it happens that beforeTestClass for test class A is run on a
thread
+ // and next beforeTest (and thus test execution) for tests from
class B are run on that thread
+ // as the browser is thread-local reused, we need to set the
report group here or the report
+ // eventually is written to the wrong report group which is
confusing and makes some tests flaky
+ getBrowser().reportGroup(testClass)
Review Comment:
It's the same as it should always have been and also was if not by chance a
thread executed the `beforeTestClass` of one class and then immediately the
`beforeTest` of a different class. And yes, this of course is still
overridable. :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
