jonnybot0 commented on PR #271: URL: https://github.com/apache/groovy-geb/pull/271#issuecomment-2895109626
TBH, this feels a bit too much like a hack. I can see how the race condition could exist, but I'd rather do something like: 1. Break out the tests that rely on the JS bits (those introduced in c30bf9909bac0f7e41e08106320fd59671bee38d and 48d696bfb28c5d90181805218a43f091fd1b3094) into a separate file that serves a page with the javascript that overwrites the page link 2. Change the HTML served in setupSpec so that it can vary somehow (maybe sticking it in a shared field?) though that feels hacky too, and would probably be easier to just write a distinct spec for. Selectively enabling/disabling JS makes the spec feel overloaded and hard to understand, particularly to squash some flakiness that we haven't seen much of lately. I wonder if it was peculiar to the old CircleCI stuff that was more of a going concern back in October. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
