This is an automated email from the ASF dual-hosted git repository. jonnybot pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/groovy-geb.git
commit 97deccabf3eb821b808602c87981cfe0c45c3395 Author: Mattias Reichel <[email protected]> AuthorDate: Mon Sep 22 20:56:24 2025 +0200 fix(webstorage): feedback - use `Object.keys` --- .../geb-core/src/main/groovy/geb/webstorage/LocalStorage.groovy | 8 +------- .../geb-core/src/main/groovy/geb/webstorage/SessionStorage.groovy | 8 +------- 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/module/geb-core/src/main/groovy/geb/webstorage/LocalStorage.groovy b/module/geb-core/src/main/groovy/geb/webstorage/LocalStorage.groovy index 3df86793..ae5f8a94 100644 --- a/module/geb-core/src/main/groovy/geb/webstorage/LocalStorage.groovy +++ b/module/geb-core/src/main/groovy/geb/webstorage/LocalStorage.groovy @@ -45,13 +45,7 @@ class LocalStorage implements WebStorage { @Override Set<String> keySet() { - js.exec(''' - var out = []; - for (var i = 0; i < window.localStorage.length; i++) { - out.push(window.localStorage.key(i)); - } - return out; - ''') as Set<String> + js.exec('Object.keys(window.localStorage);') as Set<String> } @Override diff --git a/module/geb-core/src/main/groovy/geb/webstorage/SessionStorage.groovy b/module/geb-core/src/main/groovy/geb/webstorage/SessionStorage.groovy index 92722d11..6d882313 100644 --- a/module/geb-core/src/main/groovy/geb/webstorage/SessionStorage.groovy +++ b/module/geb-core/src/main/groovy/geb/webstorage/SessionStorage.groovy @@ -45,13 +45,7 @@ class SessionStorage implements WebStorage { @Override Set<String> keySet() { - js.exec(''' - var out = []; - for (var i = 0; i < window.sessionStorage.length; i++) { - out.push(window.sessionStorage.key(i)); - } - return out; - ''') as Set<String> + js.exec('Object.keys(window.sessionStorage);') as Set<String> } @Override
