cbmarcum commented on PR #289: URL: https://github.com/apache/groovy-geb/pull/289#issuecomment-3444486156
@jonnybot0, I do not have any cases where I change the per thread cache during tests at all. Like you, I use implicit caching. #270 fixed flaky test case issues which is good and this PR fixes the issue with that. It seems the main issue is when users are changing that configuration setting during a run (does anybody?). Unless @Vampire would rather have #270 reverted, I would go with this fix and prefer documentation that users beware changing that configuration is unpredictable. (I could help with that). Reverting #270 also does not affect my uses but I would rather not have flaky tests :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
