matrei commented on PR #306: URL: https://github.com/apache/groovy-geb/pull/306#issuecomment-4176377144
Hi @jonnybot0, here are fresh build scans from `grails-core` with: - (A) `geb-spock:8.0.1`: https://develocity.apache.org/s/2qxlt7n4azbwq - (B) `geb-spock:8.0.99-SNAPSHOT` (PR changes loaded from mavenLocal): https://develocity.apache.org/s/lmjyrrnzz33sm and a comparison: https://develocity.apache.org/c/2qxlt7n4azbwq/lmjyrrnzz33sm/task-inputs I filtered to only run the Geb tests instead of running all integration tests to get more meaningful results. On this particular machine and these particular runs: Compiling tests: `3m 35.889s` vs `3m 20.419s` which is a `15.470s` or `7.2%` performance improvement. Running tests: `15m 47.155s` vs `15m 42.096s` which is a `5.059s` or `0.53%` performance improvement. I totally understand that you stress the importance of not introducing breaking changes. I targeted `8.0.x` as there should be no API differences, and both Geb and Grails test suites came up clean. I added a `DynamicDispatchCompatibilitySpec`, to test some scenarios. Maybe you know of other ways this PR could break existing code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
