> That's not my call but I certainly prefer omitting prentheses > around the value of return statements. > > Since the majority of return statements (at least in libgeda/src) > avoid these useless parentheses, it might be a good idea to remove > these superfluous (and ugly IMO) decorators whenever a patch affects > return statements.
I'm all for that in general, however statements where bracketing aids clarity should be left.. e.g.: return ( test_conditon == foo ); (To return TRUE / FALSE) or return ( test_conditon == foo ) ? "True" : "False"; In general though, its probably best to avoid too much change as part of a code patch series, as when patches might get applied out of order, it just causes more pain for everyone involved. (Yes, I know I have a couple of whitespace "fix" patches in my stack at the moment, however without them the code becomes far less readable. They were split from a re-factoring patch explicitly to make the delta easier to review.) Best wishes, -- Peter Clifton Electrical Engineering Division, Engineering Department, University of Cambridge, 9, JJ Thomson Avenue, Cambridge CB3 0FA Tel: +44 (0)7729 980173 - (No signal in the lab!) _______________________________________________ geda-dev mailing list [email protected] http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev
