Hi Dan, Stuart,

Dan McMahill <[EMAIL PROTECTED]> writes:

> Stuart Brorson wrote:
>> cvs co -v STABLE_1_X_branch gerbv

That one does not draw drill holes, and the arc angles rounding is
still wrong.

>> * If you have any devilish gerbers which test some arcane Gerber
>> corner-case feature, and you can share them with the world, please
>> e-mail them to me and I will include them into the "examples"
>> directory for use in testing as we move forward.

I'll attach a routing layer abused as board outline layer with those
arcs.  Nothing devilish, though.

>> * If you had submitted patches to gerbv over the last 1 1/2 years,
>> and had based your patch on a development branch of gerbv, there is
>> a good chance I did *not* apply your patch.  The reason is that
>> there are several conflicting branches in the gerbv tree, and the
>> developement branches are badly broken (i.e. won't compile at all).


RCS file: /cvsroot/gerbv/gerbv/src/draw.c,v
retrieving revision 1.37
diff -u -r1.37 draw.c
--- draw.c      28 Dec 2004 22:25:18 -0000      1.37
+++ draw.c      19 Nov 2007 21:01:38 -0000
@@ -51,7 +51,7 @@
 gerbv_draw_circle(GdkPixmap *pixmap, GdkGC *gc, 
                  gint filled, gint x, gint y, gint dia)
 {
-    static const gint full_circle = 23360;
+    static const gint full_circle = 23040; // 360*64
     gint real_x = x - dia / 2;
     gint real_y = y - dia / 2;
     
@@ -129,7 +129,7 @@
     gint real_y = y - height / 2;
 
     gdk_draw_arc(pixmap, gc, FALSE, real_x, real_y, width, height, 
-                (gint)angle1 * 64.0, (gint)(angle2 - angle1) * 64.0);
+                (gint)(angle1 * 64.0), (gint)((angle2 - angle1) *
64.0));
     
     return;
 } /* gerbv_draw_arc */


> Sorry, but thats not the experience I'm having.  The trunk is
> building fine for me.  The only thing I had to do was replace 1 call
> to cosf() with a call to cos() and one call to sinf() to sin().  Can
> you elaborate on the problems you're having?

The trunc does not draw arcs at all :-(

Cheers
Stephan

Attachment: v06s.group2.gbr
Description: Gerber with Arcs


_______________________________________________
geda-dev mailing list
[email protected]
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev

Reply via email to