On Thu, 2008-01-03 at 08:42 -0500, Stuart Brorson wrote: > Hi -- > > > As promised (when I authored a patch which broke spice-sdb in favour of > > fixing pinnumber updates), I have done a bit of work to restore the > > spice-sdb slotting functionality without any need to adjust pinseq > > attributes. > > Thank you for doing this! I've had a nagging worry about the slotting > problem with spice-sdb for a while. I suppose I could have done > something about it..... > > [....] > > > Comments? > > I guess my biggest question is: Do all the unit tests still pass?
They do! ;) I had to re-order the output lines in the spice-sdb slotted test's golden file though, as the components are hit in a slightly different order. The test suite was amazing for catching bugs whilst developing the changes. It caught a mistake I'd introduced when re-ordering the code in gnetlist.c and gnetlist.scm. (Some scheme defines I needed to move to gnetlist-post.scm, as they needed evaluation _after_ schematic traversal.) -- Peter Clifton Electrical Engineering Division, Engineering Department, University of Cambridge, 9, JJ Thomson Avenue, Cambridge CB3 0FA Tel: +44 (0)7729 980173 - (No signal in the lab!) _______________________________________________ geda-dev mailing list [email protected] http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev
