On Sun, 2008-01-06 at 11:13 +0100, Werner Hoch wrote:
> Hi Ales,
> 
> On Sonntag, 6. Januar 2008, Ales Hvezda wrote:
> >     I would like to release gEDA/gaf 1.3.1 on 2008/01/10 (this coming
> > Thursday).  Translators, please check over your translation and do
> > any necessary updates.  Anybody else who wants something commited,
> > please speak up now.
> 
> There's one thing:
> 
> * fix the codeset issue with libgeda and log_message:
> http://sourceforge.net/tracker/index.php?func=detail&aid=1863190&group_id=161080&atid=818426
> 
> Either apply Peter's patch, or completly track all usages of system 
> variables encoded in a different codeset.

Having looked into the problem, I realise the patch was completely bogus
(aside from a debugging exercise).

> I'll try the combination of Peters patch and the 
> bind_textdomain_codeset(GETTEXT_PACKAGE, "UTF-8"); in libgeda today.

This line is sufficient, but we are left with the problem of unsanitised
filenames in the system locale being passed to GTK (specifically the log
window which makes it abort).

I'll knock up a new patch which validates the characters before they are
inserted into the log window, that we log UTF-8 messages correctly, and
anything containing non-UTF-8 characters can emit a warning message
instead.

At appropriate places, the file-name can be converted with
g_filename_to_utf8(), but with validation in place, this need not all be
done 100% in one hit. Each one we catch brings us closer to perfection
though ;)

-- 
Peter Clifton

Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA

Tel: +44 (0)7729 980173 - (No signal in the lab!)



_______________________________________________
geda-dev mailing list
[email protected]
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev

Reply via email to