Poking at the extended gnetlist test-suite I've been working to add,
I've found an unexpected change in behaviour between 1.2.0 and 1.3.0.
In 1.2.0, any DRC errors cause gnetlist to exit with code 1. (Usual is
0). In 1.3.0, gnetlist exists with code 0 in either case.
I'm currently bisecting (did I mention git-bisect is an awesome tool!),
but looking at the log entries which affect gnetlist code, I suspect
this is where I'll end up:
commit e5f31fa0ba725c4a8a7dcacb47166a1468a357b6
Author: Peter TB Brett <[EMAIL PROTECTED]>
Date: Sun Dec 23 21:26:02 2007 +0000
gnetlist: Make drc2 backend not emit exceptions.
gnetlist: Make drc2 backend not emit exceptions.
The drc2 backend reports drc violations by emitting an error, but it
can do it more gracefully using the Guile display function.
diff --git a/gnetlist/scheme/gnet-drc2.scm b/gnetlist/scheme/gnet-drc2.scm
index 27d8ddb..a8cc56f 100644
--- a/gnetlist/scheme/gnet-drc2.scm
+++ b/gnetlist/scheme/gnet-drc2.scm
@@ -1038,10 +1038,12 @@
;; If there are only warnings and it's in quiet mode, then
;; do not return an error.
(if (> errors_number 0)
- (error "DRC errors found. See output file.")
+ (begin (display "DRC errors found. See output file.")
+ (newline))
(if (> warnings_number 0)
(if (not (calling-flag? "ignore-warnings-in-return-value" (gnet
- (error "DRC warnings found. See output file."))))
+ (begin (display "DRC warnings found. See output file.")
+ (newline)))))
))))
My question is:
What do we _want_ the return code to be? Does anyone use a non-zero
error code to flag DRC error as part of a workflow?
Is it something we want to support? Should I just check in the golden
files as 1.4.0 produces?
--
Peter Clifton
Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA
Tel: +44 (0)7729 980173 - (No signal in the lab!)
_______________________________________________
geda-dev mailing list
[email protected]
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev
