Hi Ales, thanks for the comments.
On Freitag, 29. Februar 2008, Ales Hvezda wrote: > > On Freitag, 22. Februar 2008, Werner Hoch wrote: > > I've put it on top of: > > http://repo.or.cz/w/geda-gaf/werner.git?a=shortlog;h=magneticnet > > Nice. I got a chance to play with it and I like it. A couple of > comments: > > 1) The use of s_tile_get_objectlists nicely simplified the search. > 2) It might be nice to put an indicator in the status bar when it is > on/off I take a look at this. I think the indicater should only be visible in the net mode. > 3) The circle indicator suffers from the inverse problem as > the grip boxes (circle drawn constant size, so they looks tiny > compared to pins when zoomed in close). Maybe this is okay/better > than the grip behavior (which is really large boxes when zoomed in > close). Yeah, I've played with a patch that increases the indicator together with the width of the net: http://repo.or.cz/w/geda-gaf/werner.git?a=shortlog;h=magneticnet It looks fine in the (net-style "thick") mode. But in the (net-style "thin") mode the marker still becomes smaller than the net endpoint markers. > 4) I like the circles as the indicators though. :) Great. > 5) I like the behavior but I don't know how it will be received by > the users at first. What are your thoughts on if it should be on by > default? I think it should stay enabled in the git repo. If there are much complains on the mailing list, it should be disabled before the next release. > 6) Also, I haven't made up my mind which parameters we need > to expose in the rc file. Maybe just the enable at first and see > what kind of feedback people have. I've currently one rc parameter to enable/disable the magnetic mode on startup, enabled by default. > Feel free to merge it to main git repo (I've looked at your code > changes and they look just dandy) so that it gets some more exposure. Thanks. Regards Werner _______________________________________________ geda-dev mailing list [email protected] http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev
