Hi all,

After some more coffee I realized that whatever is in between ()
probably gets substituted as well.

That is, if I remember this well and had enough coffee :)

Kind regards,

Bert Timmerman.

On Sat, 2008-06-07 at 08:33 +0200, Bert Timmerman wrote:
> Hi DJ and all,
> 
> In macro.h I we have:
> 
> <snipppet with all tabs --> white space>
> 
> #define ARC_LOOP(element) do {               \
>   Cardinal  n;                                     \
>   ArcTypePtr  arc;                           \
>   for (n = (element)->ArcN-1; n != -1; n--)  \
>   {                                          \
>     arc = &(element)->Arc[n]
> 
> #define ELEMENTLINE_LOOP(element) do {             \
>   Cardinal  n;                               \
>   LineTypePtr line;                          \
>   for (n = (element)->LineN-1; n != -1; n--) \
>   {                                          \
>     line = &(element)->Line[n]
> 
> #define  ELEMENTARC_LOOP(element)  do  {     \
>   Cardinal  n;                               \
>   ArcTypePtr  arc;                           \
>   for (n = (element)->ArcN-1; n != -1; n--)  \
>   {                                          \
>     arc = &(element)->Arc[n]
> 
> #define       LINE_LOOP(layer) do {                \
>   Cardinal  n;                               \
>   LineTypePtr  line;                         \
>   for (n = (layer)->LineN-1; n != -1; n--)   \
>   {                                          \
>     line = &(layer)->Line[n]
> 
> </snippet>
> 
> Question: Shouldn't the ARC_LOOP look like the following snippet ?
> 
> <snippet>
> 
> #define ARC_LOOP(layer) do {                 \
>   Cardinal  n;                                     \
>   ArcTypePtr  arc;                           \
>   for (n = (layer)->ArcN-1; n != -1; n--)    \
>   {                                          \
>     arc = &(layer)->Arc[n]
> 
> </snippet>
> 
> similar to the LINE_LOOP macro ?
> 
> As it is now, ARC_LOOP and ELEMENTARC_LOOP both only work on elements,
> while ARC_LOOP probably should work on layers.
> 
> Changing this would probably break a lot of stuff in the other source
> files.
> 
> Kind regards,
> 
> Bert Timmerman.
> 
> 
> 
> _______________________________________________
> geda-dev mailing list
> [email protected]
> http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev



_______________________________________________
geda-dev mailing list
[email protected]
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev

Reply via email to