On Sep 27, 2008, at 5:56 AM, Peter Clifton wrote:
> Nits: (Please take them for what they are.. just nits, not criticism)

These are all reasonable changes.  I'll incorporate them into the next  
patch.

> m_geometry_.... fees a bit long for a namespace. Keeping code using  
> this
> API on 80 lines will be awkward.. perhaps m_geom_... m_geo_...?

I can also move the transform functions out to m_transform.c.  This  
modification will shorten some of the function names by removing  
"geometry."  This change also makes the code more OOish.

Cheers,
Ed


_______________________________________________
geda-dev mailing list
[email protected]
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev

Reply via email to