On Tuesday 07 December 2004 03:19, Ales Hvezda wrote: > >I recently came across some symbols with strange pin syntax which > > made gattrib segfault. I have fixed gattrib to be robust against > > this syntax, but I am now wondering if the syntax is valid or not. > > This is not valid. attributes are text items which are always in > the form name=value. Anything else is not considered an attribute. > You cannot attach just plain text items as attributes. > > > [snip] > > >It has text "Vref" attached to the pin. Is this valid? > > > >Many other symbols have this construct also. > > Many? As in the ones in the symbol library? If so, I better > add some checks to gsymcheck to catch them.
There is allready a warning message if there is some text inside the pin section. It's the missing pinlabel warning. --snip-- Checking: /home/werner/daten/download/src/geda/devel/symbols/analog/CS5396-1.sym Warning: Did not find numslots= attribute, not checking slotting Warning: Missing pinlabel= attribute Warning: Missing pintype= attribute --snip-- Following symbols may have pinlabels not prefixed with "pinlabel=". I'll have a look at them. ./analog/CS5396-1.sym ./analog/inamp-1.sym ./analog/opamp-1.sym ./analog/opamp-2.sym ./cascade/cascade-filter-1.sym ./cascade/cascade-mixer-1.sym ./connector/DIN41612C48-1.sym ./connector/DIN41612C56-1.sym ./connector/DIN41612C96-1.sym ./dec/DC331-1.sym ./dec/DS8641_1.sym ./dec/LSI11BUS-1.sym ./ecl/MC100ELT23-1.sym ./linear/TDA2822M-1.sym ./linear/lm135-1.sym ./linear/lm2822-1.sym ./linear/lm2822m-1.sym ./maxim/max186-2.sym ./maxim/max189-1.sym ./maxim/max218-1.sym ./maxim/max237-1.sym ./maxim/max238-1.sym ./maxim/max3120-1.sym ./maxim/max4636-1.sym ./maxim/max4662-2.sym ./maxim/max531-1.sym ./maxim/max663-1.sym ./maxim/max664-1.sym ./maxim/max807-1.sym ./misc/PCM2702E-1.sym ./misc/SAB80C537-1.sym ./misc/TC5516AP-1.sym ./misc/UAA170-1.sym ./misc/dac08sm-1.sym ./misc/input-orcad-1.sym ./misc/tl16c554afn-1.sym ./misc/vicor_gen1.sym ./national/ADC0804-1.sym ./opto/hcpl-2630-1.sym ./power/vcc-orcad-circle-1.sym ./radio/af_output_transformer-1.sym ./radio/if_trans_aircore-1.sym ./radio/loop_antenna-1.sym ./radio/loop_antenna-2.sym ./radio/osc_coil_aircore-1.sym ./rf/vipec-analysis-1.sym ./supervisor/adm707.sym ./switch/relay-1.sym ./transistor/2N5245-1.sym ./transistor/2N5911-1.sym ./transistor/2S2K3-1.sym ./transistor/ULN2801A-1.sym ./verilog/low-1.sym ./vhdl/opad6-1.sym regards Werner
