El s�b, 12-02-2005 a las 20:50 -0500, Ales Hvezda escribi�: > Hi Carlos, > > [snip] > >I have modified gattrib, gschem and geda so they use GTK stock buttons. > >These are default buttons defined by GTK with text and icons. > >In some cases, there isn't the exact button for an action, so I chose > >the one which best suit. > > > >I hope you like them! > > I like them! :) > > For the most part your choices were perfect, with the exception of > one. In the page manager, the "Discard Page" button is the cancel button. > This is really going to confuse users. I think there are two possible fixes: > > 1) Pick an icon or just some text which reflects the discard page. > > 2) Remove the discard page button completely. > > I'm actually in favor for #2 since there is no good reason to have it there.
I have just commited the changes needed by #2 into CVS. I commented the lines defining the "Discard page" button, so it isn't shown anymore. Also added a new function, taken from the Evolution code, which creates a button with a given text and an icon from the GTK stock. I didn't see any file for misc functions, so I placed it in x_pagesel.nw file. Is there a better place? This allows to have another #3 option, which is to have buttons with the icon in the GTK stock, and a given text. In that case "Discard Page". This option is easy to be tested: just comment a line of the code, and uncomment another one, in the function pagesel_init. Cheers, Carlos -- Carlos Nieves �nega <[EMAIL PROTECTED]> ---Publicidad-------------------------------------------------------- Nuevo Messenger Multimedia de Yahoo � Desc�rgalas Gratis ! http://tracker.tradedoubler.com/click?p!420&a38692
