On Fri, 10 Feb 2012 09:03:39 +0100, Eike Krumbacher <[email protected]> wrote: > Hi Peter! > > Sorry, I have limited time today, so I send you the patches attached. > They are based on my local git HEAD which is from 06. Feb. > > make check passes and the patches are carefully tested with the running > gschem and gattrib and some testfiles. > > All the patches are about removing deprecated symbols. I replaced them > with their modern variants. > > I hope, this fits your needs.
Hi Eike, Thanks for the patches -- I can confirm that they apply cleanly. :-) There's a problem, though. We currently try and support GTK+ >= 2.16.0. Unfortunately, GtkComboBoxText was only introduced in 2.24.0. I can't even compile your patches on my workstation that runs Fedora 14 (GTK+ 2.22.0), and I know we have several users who run older distros. I'm not sure what the best thing is to do about this is, since your patches appear to be correct! As a rule of thumb, we try to support versions of our dependencies at least 2 years old. What do you think the best option is? I *have* pushed 0003-I-compiled-using-the-compiler-option.patch, though, since it didn't add usage of any very new API. Best wishes, Peter -- Peter Brett <[email protected]> Remote Sensing Research Group Surrey Space Centre -- Mailing list: https://launchpad.net/~geda-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~geda-developers More help : https://help.launchpad.net/ListHelp
