Hans Nieuwenhuis wrote: > Hi, > > My apologies if this too off-topic for this list but I have a question > about two functions in gui-dialog-print.c in pcb. > > I am trying to implement some GUI attributes in the HID_attributes struct > (after some discussion with DJ the other day). Up until now I and quite > successful in doing that, see the screenshot below: > > http://www.xs4all.nl/~vzzbx/files/ps-export.jpg > > One thing is baffelling me, in the aforementioned file there is a > function ghid_dialog_print (which I have modified) and the function > ghid_attribute_dialog (not modified). Apart from one mention in the HID > structure in gtkhid-main.c the latter never seems to get called. Both > functions seem to do the same besides having different call parameters. > > The export dialog seems to work fine in all cases I tested: > - export through menu > - export in batch mode > > Is ghid_attribute_dialog() obsolete and would it be better if removed? I > can also just copy my changes from ghid_dialog_print() to > ghid_dialog_print(), but that feels not like the right thing(TM).
No, quite the opposite. ghid_dialog_print() is obsolete and I haven't gotten to replacing it with ghid_attribute_dialog yet. BTW, ghid_attribute_dialog is in fact used by the printer calibration. Search for gui->attribute_dialog. I have a couple of patches which touch ghid_attribute_edit too that I haven't checked in. Mostly they are needed to let me get rid of the ghid_dialog_print() function. I'm hoping to get that done over the next few days, but I can't promise that. ghid_dialog_print() will probably go away at that time since it is less general purpose. -Dan _______________________________________________ geda-user mailing list [email protected] http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
