Hi, Am So den 5. Apr 2009 um 16:00 schrieb Klaus Ethgen: > If you edit a helper keyword and press Ok without changing the type it > is reset to TRUE. > > The reason is that for a reason I do not know until now the function > bar_pane_keywords_conf_set_kw is called once if the value is FALSE.
Ok, I fixed that. See the attached patch. The problem is that the placing of the second radio instantly call the callback once if it is set. Regards Klaus -- Klaus Ethgen http://www.ethgen.de/ pub 2048R/D1A4EDE5 2000-02-26 Klaus Ethgen <kl...@ethgen.de> Fingerprint: D7 67 71 C4 99 A6 D4 FE EA 40 30 57 3C 88 26 2B
>From fc4cddad6724bb633ab503a6b0600735da03fd59 Mon Sep 17 00:00:00 2001
From: Klaus Ethgen <kl...@ethgen.de>
Date: Sun, 5 Apr 2009 16:06:18 +0100
Subject: [PATCH] Fix the is_keyword bug
---
src/bar_keywords.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/bar_keywords.c b/src/bar_keywords.c
index da6832a..a93275c 100644
--- a/src/bar_keywords.c
+++ b/src/bar_keywords.c
@@ -875,7 +875,6 @@ static void bar_pane_keywords_edit_dialog(PaneKeywordsData *pkd, gboolean edit_e
cdd->pkd =pkd;
cdd->click_tpath = pkd->click_tpath;
pkd->click_tpath = NULL;
- cdd->is_keyword = is_keyword;
cdd->edit_existing = edit_existing;
cdd->gd = gd = generic_dialog_new(name ? _("Edit keyword") : _("Add keywords"), "keyword_edit",
@@ -903,11 +902,14 @@ static void bar_pane_keywords_edit_dialog(PaneKeywordsData *pkd, gboolean edit_e
group = pref_group_new(gd->vbox, FALSE, _("Keyword type:"), GTK_ORIENTATION_VERTICAL);
button = pref_radiobutton_new(group, NULL, _("Active keyword"),
- (cdd->is_keyword),
+ (is_keyword),
G_CALLBACK(bar_pane_keywords_conf_set_kw), cdd);
button = pref_radiobutton_new(group, button, _("Helper"),
- (!cdd->is_keyword),
+ (!is_keyword),
G_CALLBACK(bar_pane_keywords_conf_set_helper), cdd);
+
+ cdd->is_keyword = is_keyword;
+
g_free(name);
gtk_widget_grab_focus(cdd->edit_widget);
--
1.6.2.1
signature.asc
Description: Digital signature
------------------------------------------------------------------------------
_______________________________________________ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
