Hi Andre, thanks for your mail. I'd like to apply your patch to the master branch, but it seems to be still fixed there. This seems to get fixed in 2009-09-06 14:01:03 by Vladimir.
Please have a look at cf90f24, the most current version on master[0]. However, I forwarded your mail to the devel list too. Regards Klaus [0] git://gitorious.org/geeqie/geeqie.git -- Klaus Ethgen http://www.ethgen.ch/ pub 4096R/4E20AF1C 2011-05-16 Klaus Ethgen <kl...@ethgen.de> Fingerprint: 85D4 CA42 952C 949B 1753 62B3 79D0 B06F 4E20 AF1C
--- Begin Message ---Hi I've tried to send the fix below to geeqie-devel. But the mail was rejected, presumably because I'm not subscribed. Maybe you can apply it or forward it to the proper destination. Thanks Andre ----- Forwarded message from geeqie-devel-ow...@lists.sourceforge.net ----- Date: Mon, 29 Jul 2013 18:17:06 +0000 From: geeqie-devel-ow...@lists.sourceforge.net To: m...@systemlinux.org Subject: [PATCH] Avoid endless loop on exit. You are not allowed to post to this mailing list, and your message has been automatically rejected. If you think that your messages are being rejected in error, contact the mailing list owner at geeqie-devel-ow...@lists.sourceforge.net. Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from <m...@systemlinux.org>) id 1V3s0H-0007dr-En for geeqie-devel@lists.sourceforge.net; Mon, 29 Jul 2013 18:17:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:MIME-Version:Message-ID:Subject:To:From:Date; bh=eTedQMKgHcCDrOl7s9rWsXCU9EcOrbsh90QXA4Q9AgA=; b=pacwEZ+oy7OWiB4bh9WiLpGWrjGsRvdElDM52VxbnI2x52Ki0eUt4hO4YJeGffh1XBCdHxiy2g2KR5QT0yKWQoX+gAh4W/7vgHVqT6CKs84Ogmt9iIq7nMI6RIzNuN2H5hC0l2TqZuseHwIUCS0luKgf0ZVM/2yZmfMXhTiKxA4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x; h=Content-Type:MIME-Version:Message-ID:Subject:To:From:Date; bh=eTedQMKgHcCDrOl7s9rWsXCU9EcOrbsh90QXA4Q9AgA=; b=cxcBvDqRTrdkf3MRWc7SgkHF2U08TqzCE64TSUwwoMN91MIFbo/gxu0O84ivzZ/tX5Kq0Osu0Qm7WA51UPrz2C/klvG0c5DvXIPFt9qysMV2RGmGC0EJ2zKbu0uQW9OIztdPy934J7dX7OXfEQJh0M44NYlFFAFXfHO6SNi1w+I=; X-ACL-Warn: Received: from systemlinux.org ([79.140.41.46] helo=v3-1046.systemlinux.org) by sog-mx-3.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1V3s0E-0004iE-PI for geeqie-devel@lists.sourceforge.net; Mon, 29 Jul 2013 18:17:05 +0000 Received: by v3-1046.systemlinux.org (Postfix, from userid 1002) id F31BA21E1BA; Mon, 29 Jul 2013 20:01:44 +0200 (CEST) Date: Mon, 29 Jul 2013 20:01:44 +0200 From: Andre Noll <m...@systemlinux.org> To: geeqie-devel@lists.sourceforge.net Subject: [PATCH] Avoid endless loop on exit. Message-ID: <20130729180144.ge29...@systemlinux.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TD8GDToEDw0WLGOL" Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) X-Spam-Score: -1.5 (-) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain X-Headers-End: 1V3s0E-0004iE-PI On exit layout_editors_reload_finish() is called. This function calls layout_editors_reload_idle_cb() until layout_editors_reload_idle_id equals -1. However, if layout_editors_desktop_files is NULL, layout_editors_reload_idle_cb() returns early without changing layout_editors_reload_idle_id. This leads to a busy loop on exit. This patch fixes the problem by setting layout_editors_reload_idle_id to -1 in this case. Signed-off-by: Andre Noll <m...@systemlinux.org> --- src/layout_util.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/layout_util.c b/src/layout_util.c index e667449..dfd8198 100644 --- a/src/layout_util.c +++ b/src/layout_util.c @@ -2007,6 +2007,7 @@ static gboolean layout_editors_reload_idle_cb(gpointer data) { DEBUG_1("%s layout_editors_reload_idle_cb: get_desktop_files", get_exec_time()); layout_editors_desktop_files = editor_get_desktop_files(); + layout_editors_reload_idle_id = -1; return TRUE; } -- 1.8.3.1.487.g3e7a5b4 ----- End forwarded message ----- -- The only person who always got his work done by Friday was Robinson Crusoe
signature.asc
Description: Digital signature
--- End Message ---
signature.asc
Description: Digital signature
------------------------------------------------------------------------------ Get your SQL database under version control now! Version control is standard for application code, but databases havent caught up. So what steps can you take to put your SQL databases under version control? Why should you start doing it? Read more to find out. http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
_______________________________________________ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
