Changes since v1: This version pops up a dialog to notify the user that
there was an error in the drag and drop operation.

Since warning_dialog() is non-modal, and there's no upper limit to the
number of problematic URIs, uri_pathlist_from_uris() will accumulate and
return a list of URIs that failed g_filename_from_uri(). A helper
function was added for callers of uri_filelist_from_uris() to handle
showing the dialog.


Here's a patch to fix a crash that I've been hitting for a while. The
issue is that when dragging and dropping from Xfe (a light-weight file
explorer,, paths aren't escaped like they
are when dnd'ing from a GTK app. If the filename has characters that are
reserved per URI rules (e.g. 'test # one'), g_filename_from_uri()
returns null and geeqie crashes with a SIGSEGV.

To fix it, the patch checks if the conversion failed due to a bad URI.
If so, it manually escapes the URI and tries to convert again. 

This probably isn't specific to Xfe, but that's the only non-GTK/QT
program I use that can drag and drop.

Jonathan Boeing (1):
  Fix crash on drag and drop from xfe

 src/ui_bookmark.c |  8 ++++++-
 src/uri_utils.c   | 66 +++++++++++++++++++++++++++++++++++++++++++++++++------
 src/uri_utils.h   |  5 +++--
 3 files changed, 69 insertions(+), 10 deletions(-)


Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!;130105516;z
Geeqie-devel mailing list

Reply via email to