----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/977/#review1814 -----------------------------------------------------------
configs/common/Options.py <http://reviews.m5sim.org/r/977/#comment2338> This should probably be a choices type rather than a string. Might also make sense to have a --cpu option that is also a choices instead of the current atomic/timing/detalied/etc configs/common/Simulation.py <http://reviews.m5sim.org/r/977/#comment2339> if you did that then run_with_cpu could go away and you could have options.cpu == options.restore_with_cpu - Ali On 2012-01-04 03:59:49, Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/977/ > ----------------------------------------------------------- > > (Updated 2012-01-04 03:59:49) > > > Review request for Default. > > > Summary > ------- > > Config: Add support for restoring using a timing CPU > Currently there is an assumption that restoration from a checkpoint will > happen by first restoring to an atomic CPU and then switching to a timing > CPU. This patch adds support for directly restoring to a timing CPU. It > adds a new option '--restore-with-cpu' which is used to specify the type > of CPU to which the checkpoint should be restored to. It defaults to > 'atomic' which was the case before. > > > Diffs > ----- > > configs/common/Options.py 09b482ee9ae0 > configs/common/Simulation.py 09b482ee9ae0 > > Diff: http://reviews.m5sim.org/r/977/diff > > > Testing > ------- > > > Thanks, > > Nilay > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
