Hello Curtis Dunham,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/2961
to review the following change.
Change subject: util: Fix incorrect use of m5_loadsymbol
......................................................................
util: Fix incorrect use of m5_loadsymbol
It seems like the m5 utility incorrectly called m5_loadsymbol instead
of m5_addsymbol. Judging by the signature of the loadsymbol command,
the expected behavior is to add a new symbol to gem5's symbol
table. This is behavior is implemented by m5_addsymbol.
Change-Id: I83b61c48d6f8d7b1e8b57d884dfca00481c83c3a
Signed-off-by: Andreas Sandberg <[email protected]>
Reviewed-by: Curtis Dunham <[email protected]>
---
M util/m5/m5.c
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/util/m5/m5.c b/util/m5/m5.c
index 8e6f4fc..ee92134 100644
--- a/util/m5/m5.c
+++ b/util/m5/m5.c
@@ -241,14 +241,14 @@
}
void
-do_load_symbol(int argc, char *argv[])
+do_addsymbol(int argc, char *argv[])
{
if (argc != 2)
usage();
uint64_t addr = strtoul(argv[0], NULL, 0);
char *symbol = argv[1];
- m5_loadsymbol(addr, symbol);
+ m5_addsymbol(addr, symbol);
}
void
@@ -320,7 +320,7 @@
{ "writefile", do_write_file, "<filename>" },
{ "execfile", do_exec_file, "" },
{ "checkpoint", do_checkpoint, "[delay [period]]" },
- { "loadsymbol", do_load_symbol, "<address> <symbol>" },
+ { "addsymbol", do_addsymbol, "<address> <symbol>" },
{ "initparam", do_initparam, "[key] // key must be shorter
than 16 chars" },
{ "sw99param", do_sw99param, "" },
#ifdef linux
--
To view, visit https://gem5-review.googlesource.com/2961
To unsubscribe, visit https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I83b61c48d6f8d7b1e8b57d884dfca00481c83c3a
Gerrit-Change-Number: 2961
Gerrit-PatchSet: 1
Gerrit-Owner: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Curtis Dunham <[email protected]>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
